Skip to content
This repository has been archived by the owner on Apr 26, 2024. It is now read-only.

add poll_frequency_seconds to snowflake queries (#28) #29

Merged
merged 4 commits into from Aug 22, 2022

Conversation

thesubneo
Copy link
Contributor

@thesubneo thesubneo commented Aug 22, 2022

Summary

Current implementation cannot run ~10 queries concurrently.

Relevant Issue(s)

#28

Checklist

suresh-aqfer
suresh-aqfer previously approved these changes Aug 22, 2022
@desertaxle desertaxle mentioned this pull request Aug 22, 2022
1 task
@desertaxle
Copy link
Member

Thanks for the contribution @thesubneo! Once the changelog update in #30 is included in this PR, this will be good to merge!

@ahuang11
Copy link
Contributor

Hi! It all looks good to me, but if you'd like, you can add your name to https://github.com/PrefectHQ/prefect-snowflake/blob/main/CONTRIBUTORS.md too!

@thesubneo
Copy link
Contributor Author

I have updated CHANGELOG.md here

Copy link
Contributor

@ahuang11 ahuang11 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just minor suggestion

CHANGELOG.md Outdated Show resolved Hide resolved
CHANGELOG.md Outdated Show resolved Hide resolved
thesubneo and others added 2 commits August 22, 2022 19:25
Co-authored-by: Andrew <15331990+ahuang11@users.noreply.github.com>
Co-authored-by: Andrew <15331990+ahuang11@users.noreply.github.com>
Copy link
Contributor

@ahuang11 ahuang11 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Awesome!! Thanks so much for adding this

@desertaxle desertaxle merged commit d60afa1 into PrefectHQ:main Aug 22, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants