This repository has been archived by the owner on Apr 26, 2024. It is now read-only.
add poll_frequency_seconds to snowflake queries (#28) #29
Merged
desertaxle
merged 4 commits into
PrefectHQ:main
from
thesubneo:Issue_28_poll_frequency_seconds
Aug 22, 2022
Merged
add poll_frequency_seconds to snowflake queries (#28) #29
desertaxle
merged 4 commits into
PrefectHQ:main
from
thesubneo:Issue_28_poll_frequency_seconds
Aug 22, 2022
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
suresh-aqfer
previously approved these changes
Aug 22, 2022
Thanks for the contribution @thesubneo! Once the changelog update in #30 is included in this PR, this will be good to merge! |
Hi! It all looks good to me, but if you'd like, you can add your name to https://github.com/PrefectHQ/prefect-snowflake/blob/main/CONTRIBUTORS.md too! |
I have updated CHANGELOG.md here |
ahuang11
suggested changes
Aug 22, 2022
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Just minor suggestion
Co-authored-by: Andrew <15331990+ahuang11@users.noreply.github.com>
Co-authored-by: Andrew <15331990+ahuang11@users.noreply.github.com>
ahuang11
approved these changes
Aug 22, 2022
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Awesome!! Thanks so much for adding this
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Current implementation cannot run ~10 queries concurrently.
Relevant Issue(s)
#28
Checklist