Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix blobby multi-word state on flow run bar chart popover #2208

Merged

Conversation

collincchoy
Copy link
Collaborator

@collincchoy collincchoy commented Mar 12, 2024

Users can return their own custom name/message for a flow run's state.

For example via:

@flow
def hello_world():
    return State(
        type=StateType.COMPLETED,
        name="My custom name",
        message="My custom message.",
    )

The above message renders in a little goofily for the flow run bar chart popover though which this PR addresses.

Before |-> After
image

@collincchoy collincchoy marked this pull request as ready for review March 13, 2024 16:16
@collincchoy collincchoy requested a review from a team as a code owner March 13, 2024 16:16
@collincchoy collincchoy merged commit bfaf593 into main Mar 13, 2024
3 checks passed
@collincchoy collincchoy deleted the fix/flow-runs-bar-chart-popover-statebadge-multiword-states branch March 13, 2024 16:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants