Fix: Remove old flow run infra override access checks #2417
Conversation
|
@zhen0 Yes, this looks right, we should have removed this alongside the other PR. |
|
nvm my guess above was wrong. I don't see any server-side support for job variables at the schedule level so we do still want to keep that UI behavior turned off. altho if we decided to nix that medium-to-long-term then feature-flagged UI behavior there is confusing. |
| @@ -124,7 +124,7 @@ | |||
| const workQueueName = ref<string | null>(props.deployment.workQueueName) | |||
| const retries = ref<number | null>(null) | |||
| const retryDelay = ref<number | null>(null) | |||
| const jobVariables = ref<string | undefined>(can.access.flowRunInfraOverrides ? '{}' : undefined) | |||
| const jobVariables = ref<string | undefined>('{}') | |||
There was a problem hiding this comment.
I feel like a bunch of handling could get simplified now by removing this | undefined in places....
but this should all work as-is
There was a problem hiding this comment.
it looks the API itself calls this field optional so technically the typing is correct but it'd certainly make everything simpler if we stuck to a single type especially if we're defaulting to a defined value.
probably not worth the headache atm tho tbh
PrefectHQ/prefect#12742 removed experimental flags for flow run infra overrides. However the UI still contains access checks meaning that users in OSS can not access or view the flow run infra overrides section of the custom run form (and elsewhere).
This PR removes the access checks. Accompanying PR in PrefectHQ/prefect#13401