-
Notifications
You must be signed in to change notification settings - Fork 1.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
anyio 4.0.0
introduces breaking changes for prefect
#10567
Comments
The earlier we can get this in the better - @zzstoatzz can you figure out where that function moved to? |
anyio 4.0.0
breaks prefect due to moved imports anyio 4.0.0
introduces breaking changes for prefect
it moved to from anyio.from_thread import start_blocking_portal but it seems the more gnarly issue might be the backwards imcompatable changes to cancellation here |
We're getting this same failure when running the below command in a CI context. We haven't experienced this yet in our local machines and I will ask folks to avoid upgrading anything for now. But we would like to be able to commit new code. :) |
Downgrading anyio to 3.7.1 temporarily solves the issue. |
A question to the Prefect engineering team - Why aren't you pinning the requirements, or at least using |
This is breaking |
@ori-scala good question: as a library, we try to be as liberal as possible with our dependencies (until we know there's a specific incompatibility of course - the next release will include an upper bound for I don't think we have this documented clearly anywhere, so this is a good reminder - we'll write up a guide in our docs and I'll link to it here when it's ready for reference. |
@cicdw Thank you Chris for the detailed explanation. Going forward, we will be pinning every dependency in Prefect's would have:
Also note the exact same thing happen last month with PyDantic: #10143 |
The |
If you decide to major version upper bounds, please can you upstream this to conda-forge too: https://github.com/conda-forge/prefect-feedstock/blob/main/recipe/meta.yaml |
appeared again today |
@JustinGuese can you say more? Prefect requires |
changelog for
anyio
here detailing backwards incompatible changes to cancellation semanticsFirst check
Bug summary
anyio==4.0.0
seems to include a breaking change that includes movingstart_blocking_portal
Reproduction
Error
Versions
Additional context
No response
The text was updated successfully, but these errors were encountered: