Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make default image tag latest (or None) for Docker storage #1237

Closed
jlowin opened this issue Jul 15, 2019 · 5 comments · Fixed by #1265
Closed

Make default image tag latest (or None) for Docker storage #1237

jlowin opened this issue Jul 15, 2019 · 5 comments · Fixed by #1265
Assignees
Labels
enhancement An improvement of an existing feature

Comments

@jlowin
Copy link
Member

jlowin commented Jul 15, 2019

Right now the image name and image tag are both random UUIDs. While this does mean that collisions are on the order of (1 / the atoms in the universe) / the atoms in the universe, having a random tag is probably redundant.

@cicdw
Copy link
Member

cicdw commented Jul 15, 2019

Ideally we would auto-tag the image name with the flow ID itself, but there's a chicken / egg problem with that.

@joshmeek joshmeek added the enhancement An improvement of an existing feature label Jul 20, 2019
@jlowin
Copy link
Member Author

jlowin commented Jul 25, 2019

Proposal:

image:tag -> {flow.name}:{timestamp}

If, in addition, we updated it with {flow.name}:latest as well, then users could trivially pull and test new builds

@cicdw
Copy link
Member

cicdw commented Jul 25, 2019

I love that.

@cicdw cicdw self-assigned this Jul 25, 2019
@cicdw
Copy link
Member

cicdw commented Jul 25, 2019

It looks like using .isoformat() or str(timestamp) violates the restrictions of docker tags, so we'll need to use something like slugify.slugify(str(pendulum.now("utc")))

@joshmeek
Copy link

Yeah I'm game for timestamp as default

abrookins pushed a commit that referenced this issue Mar 15, 2022
Allow `SettingsOption` to take typer.Option parameters
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement An improvement of an existing feature
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants