-
Notifications
You must be signed in to change notification settings - Fork 1.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Can't map
over set
#1821
Comments
Sorry for the delayed response here; the biggest reason that non-ordered collections don't play well with mapping is that in Cloud (and also somewhat in Core) we identify mapped task runs as a pair (task_run_id, map_index) where the map index corresponds to the position of the argument being mapped over. This becomes more important in situations such as retries when we need to make sure we aren't mismatching state updates. There's a decent chance we'll be refactoring mapping in the near future for performance reasons, and when we do we can revisit some of these assumptions and make sure they aren't overly stringent! |
Makes sense :) Maybe there's a different error that could be raised that makes it clearer that the behavior is intentional? Regardless feel free to close if you think this won't be addressed except as part of a larger refactor |
Example:
Currently fails on
0.7.3
with:Maybe this is expected behavior but I would have thought it would just work as long as the thing being mapped has a
len
(even if the output wasn't guaranteed to stay aset
).The text was updated successfully, but these errors were encountered: