Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Flow methods should raise a more informative error if a task is not in the flow #2

Closed
jlowin opened this issue Jun 30, 2018 · 1 comment
Closed

Flow methods should raise a more informative error if a task is not in the flow #2

jlowin opened this issue Jun 30, 2018 · 1 comment
Labels
enhancement An improvement of an existing feature

Comments

@jlowin
Copy link
Member

jlowin commented Jun 30, 2018

flow.edges_to(task) and flow.edges_from(task) (and methods that depend on them, like upstream_tasks()) raise a KeyError if the task in question is not in the Flow. The error says that the task can't be found in an edge dictionary -- perhaps we should have a more informative error saying that the task is not in the current Flow.
@jlowin jlowin added the enhancement An improvement of an existing feature label Jun 30, 2018
@jlowin
Copy link
Member Author

jlowin commented Jun 30, 2018

Closed in 4032839

@jlowin jlowin closed this as completed Jun 30, 2018
znicholasbrown added a commit to znicholasbrown/prefect that referenced this issue Aug 27, 2019
@znicholasbrown
Adds additional styling to put the copy code in the bottom right corn…
d8d39aa 
…er of the code box. Will need to update the package if/when @dovy/vuepress-plugin-clipboard-copyPrefectHQ/pull/2 is reviewed/merged, which this PR depends on.
@joeschmid joeschmid mentioned this issue Sep 10, 2019
Merged
3 tasks
@wagoodman wagoodman mentioned this issue Jan 24, 2020
Closed
AlessandroLollo referenced this issue in AlessandroLollo/prefect Feb 8, 2022
@AlessandroLollo
Merge pull request #2 from AlessandroLollo/dependabot/pip/click-gte-7…
a7980c2 
….0-and-lt-9.0

Update click requirement from <8.0,>=7.0 to >=7.0,<9.0
@bunchesofdonald bunchesofdonald mentioned this issue Nov 21, 2022
Merged
zanieb pushed a commit that referenced this issue Nov 30, 2022
@bunchesofdonald @zanieb
# This is a combination of 2 commits.
d3eed58 
# This is the 1st commit message:

Add kill method to Process infrastructure

# The commit message #2 will be skipped:

# Incorporate PR feedback
@serinamarie serinamarie mentioned this issue Jun 2, 2023
Closed
4 tasks
@prefectcboyd prefectcboyd mentioned this issue Jun 23, 2023
Closed
cicdw added a commit that referenced this issue Aug 23, 2023
@cicdw
Merge pull request #2 from PrefectHQ/no-workflows
eb42fb1 
Remove all github workflow config
@jakekaplan jakekaplan mentioned this issue Sep 12, 2023
Open
3 tasks
zangell44 added a commit that referenced this issue Jan 9, 2024
@zangell44
Actually make CI run attempt #2
8d75a3a
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
enhancement An improvement of an existing feature
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@jlowin