Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Task Run Fails to Read Upstream Result the First Time a Flow is Run on Windows #3378

Closed
dylanbhughes opened this issue Sep 23, 2020 · 2 comments · Fixed by #3567
Closed

Task Run Fails to Read Upstream Result the First Time a Flow is Run on Windows #3378

dylanbhughes opened this issue Sep 23, 2020 · 2 comments · Fixed by #3567
Assignees

Comments

@dylanbhughes
Copy link
Contributor

Description

image

it seems that the file is either getting cleaned up OR reading from the file has a bug that is specific to windows paths

Expected Behavior

Result is read properly

Reproduction

Environment

Windows

@cicdw
Copy link
Member

cicdw commented Sep 26, 2020

@dylanbhughes I am unable to reproduce on a Windows machine; I'll need some example code + configuration. Note that this could happen if you are using caching (cache_for) across multiple machines with a LocalResult

@PrefectHQ PrefectHQ deleted a comment from dylanbhughes Sep 26, 2020
@cicdw
Copy link
Member

cicdw commented Oct 23, 2020

OK after attempting to reproduce this in a few different ways, I've concluded that something external to Prefect must have deleted this file. Based on the traceback, it's clear this Task used caching, and the non-existence of the file meant that this particular Cached state could not be used.

I do think Prefect should have more gracefully handled this situation by logging a warning that we were unable to read the result and therefore will not be using that particular cache. There's no reason to fail the execution of the task here, because nonexistence of the file is equivalent to the cache being invalid IMO. Leaving this ticket open to track this UX enhancement.

@cicdw cicdw self-assigned this Oct 23, 2020
@cicdw cicdw mentioned this issue Oct 23, 2020
3 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants