Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Display all parameter values a flow run was triggered with in the UI, not only overrides #7526

Closed
3 tasks done
anna-geller opened this issue Nov 14, 2022 · 6 comments · Fixed by #7697
Closed
3 tasks done
Assignees
Labels
enhancement An improvement of an existing feature ui Related to the Prefect web interface

Comments

@anna-geller
Copy link
Contributor

First check

  • I added a descriptive title to this issue.
  • I used the GitHub search to find a similar request and didn't find it.
  • I searched the Prefect documentation for this feature.

Prefect Version

2.x

Describe the current behavior

When a user triggers a custom run from the UI, the Parameters tab only displays the overrides. Here is an example of my deployment parameters:

image

Then, I trigger a custom run from this deployment, but change the dataset parameter value to yellow_nyc. The Parameters tab, unfortunately, only displays the overrides, rather than all parameter values this flow run was triggered with (including the default parameter values):
image

Describe the proposed behavior

display all parameter values passed to the run in this tab:
image

Example Use

No response

Additional context

No response

@anna-geller anna-geller added enhancement An improvement of an existing feature ui Related to the Prefect web interface status:triage labels Nov 14, 2022
@zhen0 zhen0 added the needs:triage Needs feedback from the Prefect product team label Nov 14, 2022
@zhen0
Copy link
Member

zhen0 commented Nov 14, 2022

Thanks for this @anna-geller - right now the UI only has access to the overrides. I agree this has the potential for confusion though so marking for product feedback/discussion.

@zanieb
Copy link
Contributor

zanieb commented Nov 14, 2022

@zhen0 Aren't all of the defaults available on the deployment parameter schema?

@anna-geller
Copy link
Contributor Author

they are, 100% true

@zhen0
Copy link
Member

zhen0 commented Nov 14, 2022

Good point @madkinsz - yes they are and the UI could use that to add more complete information.

There's the odd edge case where the flow code is updated after the deployment but I think we can leave that for now.

@zhen0 zhen0 added priority:medium and removed needs:triage Needs feedback from the Prefect product team status:triage labels Nov 14, 2022
@zhen0
Copy link
Member

zhen0 commented Nov 21, 2022

Needs a merge object utility?

@pleek91
Copy link
Contributor

pleek91 commented Nov 21, 2022

We should probably use the merge method from lodash. We already utilize a couple lodash methods and this seems like something we probably don't want to implement ourselves (and there probably isn't an advantage to implementing it ourselves)

https://lodash.com/docs/4.17.15#merge

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement An improvement of an existing feature ui Related to the Prefect web interface
Projects
None yet
5 participants