Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Display all parameter values a flow run was triggered with in the UI (defaults and overrides) #7697

Merged
merged 3 commits into from Nov 30, 2022
Merged

Display all parameter values a flow run was triggered with in the UI (defaults and overrides) #7697

merged 3 commits into from Nov 30, 2022

Conversation

marichka-offen
Copy link
Contributor

This PR utilizes a utility getSchemaValuesWithDefaultsJson created for this use case in orion-design to merge flowRun parameters (overrides) and deployment defaults that the flowRun was triggered with and display them in flowRuns parameters tab

Closes #7526

Checklist

  • This pull request references any related issue by including "closes <link to issue>"
    • If no issue exists and your change is not a small fix, please create an issue first.
  • This pull request includes tests or only affects documentation.
  • This pull request includes a label categorizing the change e.g. fix, feature, enhancement

@marichka-offen marichka-offen added the fix A fix for a bug in an existing feature label Nov 30, 2022
@netlify
Copy link

netlify bot commented Nov 30, 2022 •
edited

✅ Deploy Preview for prefect-orion ready!

Name Link
🔨 Latest commit 24db124
🔍 Latest deploy log https://app.netlify.com/sites/prefect-orion/deploys/63879c22082e1300092d0b5f
😎 Deploy Preview https://deploy-preview-7697--prefect-orion.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site settings.

pleek91
pleek91 approved these changes Nov 30, 2022
View reviewed changes
Copy link
Contributor

@pleek91 pleek91 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

One suggestion. But otherwise this looks good! Using that utility looks really nice.

orion-ui/src/pages/FlowRun.vue Outdated Show resolved Hide resolved
@marichka-offen @pleek91
Update orion-ui/src/pages/FlowRun.vue
24db124 
Co-authored-by: pleek91 <pleek91@gmail.com>
@marichka-offen marichka-offen merged commit d6d906d into main Nov 30, 2022
@marichka-offen marichka-offen deleted the fix-overrides branch November 30, 2022 18:51
github-actions bot pushed a commit that referenced this pull request Dec 1, 2022
@marichka-offen @pleek91 @github-actions
Display all parameter values a flow run was triggered with in the UI …
68cad21 
…(defaults and overrides) (#7697)

Co-authored-by: pleek91 <pleek91@gmail.com>
github-actions bot pushed a commit to ddelange/prefect that referenced this pull request Dec 15, 2022
@marichka-offen @pleek91 @github-actions
Display all parameter values a flow run was triggered with in the UI …
e5ee5d4 
…(defaults and overrides) (PrefectHQ#7697)

Co-authored-by: pleek91 <pleek91@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@pleek91 pleek91 pleek91 approved these changes

Assignees
No one assigned
Labels
fix A fix for a bug in an existing feature
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Display all parameter values a flow run was triggered with in the UI, not only overrides
2 participants
@marichka-offen @pleek91