Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

task.set_*stream should have more keyword arguments #823

Closed
cicdw opened this issue Mar 24, 2019 · 0 comments · Fixed by #929
Closed

task.set_*stream should have more keyword arguments #823

cicdw opened this issue Mar 24, 2019 · 0 comments · Fixed by #929
Assignees
Labels
enhancement An improvement of an existing feature

Comments

@cicdw
Copy link
Member

cicdw commented Mar 24, 2019

Task.set_upstream and Task.set_downstream were originally envisioned as methods for building up a Flow which does not pass data. Task.set_dependencies offers a richer API for specifying data passage between tasks.

We should elevate all these methods to expose the full set of Prefect's features:

  • allow for the creation of keyed edges
  • allow for the creation of mapped edges

We might need to think about whether set_upstream and set_downstream should have the same exact options - calls where the upstream task specifies a key on the downstream task like t1.set_downstream(t2, key="y") feel unnatural.

@cicdw cicdw added this to the v0.6.0 milestone Mar 24, 2019
@jlowin jlowin added the enhancement An improvement of an existing feature label Mar 28, 2019
@cicdw cicdw self-assigned this Mar 29, 2019
@cicdw cicdw modified the milestones: v0.6.0, v0.5.2 Apr 5, 2019
zanieb pushed a commit that referenced this issue Jan 19, 2022
UI: Orion Design Updates for Logs UI
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement An improvement of an existing feature
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants