-
Notifications
You must be signed in to change notification settings - Fork 1.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
track task run params in state details to avoid quantum entanglement #11737
track task run params in state details to avoid quantum entanglement #11737
Conversation
I kept breaking things until a task ran, check it out:
|
task.persist_result = True | ||
factory = await ResultFactory.from_task(task) | ||
parameters = await factory.read_parameters(parameter_id) | ||
try: | ||
parameters = await factory.read_parameters(parameters_id) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We probably don't want this exception handler, I was just trying to cut down on the error output while the task engine couldn't find the files in storage.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This looks great, it was exactly what I was planning to do today, to add a new attribute for ourselves on state_details
. I was running short on time yesterday afternoon to explain, but the whole data
thing was totally a hack just to get something stored server-side, but this is definitely the better way
I ran through this locally with the task-scheduling-examples repo and it works well! |
…with results
Example
Checklist
<link to issue>
"maintenance
,fix
,feature
,enhancement
,docs
.For documentation changes:
netlify.toml
for files that are removed or renamed.For new functions or classes in the Python SDK:
mkdocs.yml
navigation.