Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix bug where block placeholders are not saved with pull step declared in deployments section of a prefect.yaml file #11740

Merged
merged 8 commits into from
Feb 6, 2024

Conversation

desertaxle
Copy link
Member

@desertaxle desertaxle commented Jan 26, 2024

We recently introduced the ability to resolve block document references in the deployments section of a prefect.yaml file. This introduced a bug where block references used in pull actions declared in the deployments section of a prefect.yaml would be resolved before the pull action was saved on the server, so the block document reference did not persist as expected. This PR fixes that by retrieving the pull action before block document resolution.

Checklist

  • This pull request references any related issue by including "closes <link to issue>"
    • If no issue exists and your change is not a small fix, please create an issue first.
  • This pull request includes tests or only affects documentation.
  • This pull request includes a label categorizing the change e.g. maintenance, fix, feature, enhancement, docs.

For documentation changes:

  • This pull request includes redirect settings in netlify.toml for files that are removed or renamed.

For new functions or classes in the Python SDK:

  • This pull request includes helpful docstrings.
  • If a new Python file was added, this pull request contains a stub page in the Python SDK docs and an entry in mkdocs.yml navigation.

@desertaxle desertaxle added the fix A fix for a bug in an existing feature label Jan 26, 2024
Copy link

netlify bot commented Jan 26, 2024

Deploy Preview for prefect-docs-preview ready!

Name Link
🔨 Latest commit 312e246
🔍 Latest deploy log https://app.netlify.com/sites/prefect-docs-preview/deploys/65c25e86cb1ef900082256e9
😎 Deploy Preview https://deploy-preview-11740--prefect-docs-preview.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@desertaxle desertaxle changed the title Fix bug where block placeholders are not saved with pull step declared in deployments section Fix bug where block placeholders are not saved with pull step declared in deployments section of a prefect.yaml file Jan 26, 2024
@desertaxle desertaxle marked this pull request as ready for review January 26, 2024 21:07
@desertaxle desertaxle requested a review from a team as a code owner January 26, 2024 21:07
Copy link
Contributor

@bunchesofdonald bunchesofdonald left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good!

@desertaxle desertaxle merged commit 0668b3d into main Feb 6, 2024
44 checks passed
@desertaxle desertaxle deleted the alex/fix-block-templating branch February 6, 2024 16:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
fix A fix for a bug in an existing feature
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants