Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

revert deprecation of worker webserver setting #11758

Merged
merged 5 commits into from Jan 29, 2024

Conversation

zzstoatzz
Copy link
Contributor

@zzstoatzz zzstoatzz commented Jan 29, 2024

the PREFECT_WORKER_WEBSERVER_HOST and ...PORT settings were erroneously deprecated in this PR such the default host for the worker's webserver went from 0.0.0.0 to localhost

@zzstoatzz zzstoatzz self-assigned this Jan 29, 2024
Copy link

netlify bot commented Jan 29, 2024

Deploy Preview for prefect-docs-preview ready!

Name Link
🔨 Latest commit db8f9b2
🔍 Latest deploy log https://app.netlify.com/sites/prefect-docs-preview/deploys/65b811d983008800081377fd
😎 Deploy Preview https://deploy-preview-11758--prefect-docs-preview.netlify.app/api-ref/prefect/settings
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@zzstoatzz zzstoatzz added the fix A fix for a bug in an existing feature label Jan 29, 2024
@zzstoatzz zzstoatzz marked this pull request as ready for review January 29, 2024 20:58
@zzstoatzz zzstoatzz requested a review from a team as a code owner January 29, 2024 20:58
Copy link
Contributor

@bunchesofdonald bunchesofdonald left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you!

@zzstoatzz zzstoatzz merged commit c9fd64e into main Jan 29, 2024
58 of 61 checks passed
@zzstoatzz zzstoatzz deleted the revert-worker-webserver-setting-deprecation branch January 29, 2024 21:52
@zzstoatzz zzstoatzz mentioned this pull request Jan 30, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
fix A fix for a bug in an existing feature
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants