Task subscription api retry queue #11789
Conversation
✅ Deploy Preview for prefect-docs-preview ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
There was a problem hiding this comment.
Yes! This is exactly what I was thinking! We can also look into sending a ping and awaiting its pong before we accept that the task has been delivered. This looks like:
pong = await websocket.ping()
await pongIf we put that after the send_json call, we should be pretty confident that a task server got the message.
|
hmm
looks like starlette's |
| message = await self._websocket.recv() | ||
|
|
||
| message_data = orjson.loads(message) | ||
|
|
||
| if message_data.get("type") == "ping": | ||
| await self._websocket.send(orjson.dumps({"type": "pong"}).decode()) | ||
| continue |
There was a problem hiding this comment.
Oh bummer, I thought we could use the built-in websocket.ping() but that doesn't seem to be available in the server-side sockets. This works great too!
adds a retry queue for when tasks are submitted and there is no running
TaskServerempirically this solves the problem I described earlier: