Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ft: adds GH option to ignore cache upload failures #11869

Merged
merged 2 commits into from Feb 5, 2024

Conversation

urimandujano
Copy link
Contributor

We've seen a lot of failures attempting to upload our built images to the GithubActions Cache API. This PR updates our build and upload step to ignore failures resulting from cache uploads. This should let the CI continue without using cached images. The idea here is its better for the CI run to continue without a cached image than it is to crash if we can't cache anymore.

Reference PRs:

Example

Checklist

  • This pull request references any related issue by including "closes <link to issue>"
    • If no issue exists and your change is not a small fix, please create an issue first.
  • This pull request includes tests or only affects documentation.
  • This pull request includes a label categorizing the change e.g. maintenance, fix, feature, enhancement, docs.

For documentation changes:

  • This pull request includes redirect settings in netlify.toml for files that are removed or renamed.

For new functions or classes in the Python SDK:

  • This pull request includes helpful docstrings.
  • If a new Python file was added, this pull request contains a stub page in the Python SDK docs and an entry in mkdocs.yml navigation.

@urimandujano urimandujano requested a review from a team as a code owner February 5, 2024 20:34
Copy link

netlify bot commented Feb 5, 2024

Deploy Preview for prefect-docs-preview ready!

Name Link
🔨 Latest commit 1ddecf5
🔍 Latest deploy log https://app.netlify.com/sites/prefect-docs-preview/deploys/65c14fe2de2fa60008cd2776
😎 Deploy Preview https://deploy-preview-11869--prefect-docs-preview.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

Copy link
Collaborator

@chrisguidry chrisguidry left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

That's good thinking!

@urimandujano urimandujano added the maintenance Chores and other work not directly related to the product label Feb 5, 2024
@urimandujano
Copy link
Contributor Author

I'm going to go ahead and merge this because:

  • the failure in the workflow is related to a recurring flake "Alarm based timeouts can only be used in the main thread." which is being tracked here
  • it looks like the option to ignore cache upload failures is working in this PR because we hit the timeout and the workflow was able to proceed + succeed. This should help our ongoing flake work:
exporting to GitHub Actions Cache
preparing build cache for export
preparing build cache for export 305.2s done
ERROR: maximum timeout reached
------

@urimandujano urimandujano merged commit a792894 into main Feb 5, 2024
41 of 42 checks passed
@urimandujano urimandujano deleted the fix/ignore-cache-upload-failures branch February 5, 2024 22:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
maintenance Chores and other work not directly related to the product
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants