Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

task server more explicit stop #11928

Merged
merged 5 commits into from
Feb 9, 2024
Merged

task server more explicit stop #11928

merged 5 commits into from
Feb 9, 2024

Conversation

zzstoatzz
Copy link
Contributor

@zzstoatzz zzstoatzz commented Feb 7, 2024

the existing implementation of stop doesn't really do anything anymore now that we're not polling. this PR adds an explicit raise of StopTaskServer in stop

also fixes task server sigterm test

Copy link

netlify bot commented Feb 7, 2024

Deploy Preview for prefect-docs-preview ready!

Name Link
🔨 Latest commit 1cb0e44
🔍 Latest deploy log https://app.netlify.com/sites/prefect-docs-preview/deploys/65c4f2ac128d260008b017a5
😎 Deploy Preview https://deploy-preview-11928--prefect-docs-preview.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@zzstoatzz zzstoatzz changed the title Task server fix stop task server more explicit stop Feb 8, 2024
@serinamarie serinamarie added maintenance Chores and other work not directly related to the product fix A fix for a bug in an existing feature and removed maintenance Chores and other work not directly related to the product labels Feb 8, 2024
@zzstoatzz zzstoatzz marked this pull request as ready for review February 8, 2024 17:38
@zzstoatzz zzstoatzz requested a review from a team as a code owner February 8, 2024 17:38
@chrisguidry chrisguidry merged commit f95b9ec into main Feb 9, 2024
47 checks passed
@chrisguidry chrisguidry deleted the task-server-fix-stop branch February 9, 2024 15:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
fix A fix for a bug in an existing feature
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants