-
Notifications
You must be signed in to change notification settings - Fork 1.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
prevent RUNNING
-> RUNNING
for autonomous task runs
#11975
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
✅ Deploy Preview for prefect-docs-preview ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
Running
-> Running
for autonomous task runs specificallyRunning
-> Running
for autonomous task runs
Running
-> Running
for autonomous task runsPending
-> Pending
for autonomous task runs
Pending
-> Pending
for autonomous task runsRUNNING
-> RUNNING
for autonomous task runs
….com/PrefectHQ/prefect into prevent-task-runs-running-to-running
chrisguidry
approved these changes
Feb 13, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds an
AutonomousTaskPolicy
that includes a newPreventRunningToRunningTransitions
rule to be conditionally applied for autonomous task runs.Similar to the idea behind #9447, this is primarily to address potential race conditions where the same task run is picked up by more than one
TaskServer
and submitted to the engine.Since task runs are created in
Pending
and transitioned toRunning
by the engine, we should gracefully abort any subsequent attempt to transition an alreadyRunning
task run intoRunning
.Example
Checklist
<link to issue>
"maintenance
,fix
,feature
,enhancement
,docs
.For documentation changes:
netlify.toml
for files that are removed or renamed.For new functions or classes in the Python SDK:
mkdocs.yml
navigation.