Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove cloud result handler #1198

Merged
merged 5 commits into from
Jul 2, 2019
Merged

Remove cloud result handler #1198

merged 5 commits into from
Jul 2, 2019

Conversation

cicdw
Copy link
Member

@cicdw cicdw commented Jul 1, 2019

Thanks for contributing to Prefect!

Please describe your work and make sure your PR:

  • adds new tests (if appropriate)
  • updates CHANGELOG.md (if appropriate)
  • updates docstrings for any new functions or function arguments, including docs/outline.toml for API reference docs (if appropriate)

Note that your PR will not be reviewed unless all three boxes are checked.

What does this PR change?

Removes the CloudResultHandler entirely

Closes #1197

Copy link

@joshmeek joshmeek left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can you also remove result_handler = "${cloud.api}/result-handler" from the config

@codecov
Copy link

codecov bot commented Jul 1, 2019

Codecov Report

Merging #1198 into master will decrease coverage by 0.04%.
The diff coverage is 100%.

@cicdw
Copy link
Member Author

cicdw commented Jul 1, 2019

@joshmeek good catch - done.

@cicdw cicdw requested a review from joshmeek July 2, 2019 01:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Cloud PR references Core
2 participants