[task scheduling] add intermediate Pending state and update policy
#11985
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
✅ Deploy Preview for prefect-docs-preview ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
abrookins
reviewed
Feb 14, 2024
src/prefect/task_server.py
Outdated
|
|
||
| if not state.is_pending(): | ||
| logger.exception( | ||
| f"Aborted submission of task run {task_run.id!r} -" |
There was a problem hiding this comment.
The fact that we "submit" task runs to a task runner isn't something the user should have to grapple with, IMO, because the language overlaps with Task.submit(). Also, the user can't really do much about this and they didn't do something wrong, so I'd be inclined to log a warning message for them ("Aborted task run <>. The task may already be running.") and logging something at INFO or DEBUG with the server's response, which will basically look like gibberish anyway.
There was a problem hiding this comment.
updated in f612197
zzstoatzz
commented
Feb 14, 2024
chrisguidry
approved these changes
Feb 14, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
based on discussion, we should:
SCHEDULED->PENDING->RUNNINGPENDING->PENDING(using the existingPreventPendingTransitionsrule) instead ofRUNNING->RUNNING