Add CLI command to read runs in WQ #11989
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
✅ Deploy Preview for prefect-docs-preview ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
|
|
||
| @work_app.command("read-runs") | ||
| @experimental_parameter("pool", group="work_pools", when=lambda y: y is not None) | ||
| async def read_wq_runs( |
There was a problem hiding this comment.
It'd be nice to have a couple tests around this.
There was a problem hiding this comment.
I added a few tests! Let me know if you think there are edge cases I should be testing for.
There was a problem hiding this comment.
That seems to hit all the notes, thank you!
bunchesofdonald
approved these changes
Feb 16, 2024
|
|
||
| @work_app.command("read-runs") | ||
| @experimental_parameter("pool", group="work_pools", when=lambda y: y is not None) | ||
| async def read_wq_runs( |
There was a problem hiding this comment.
That seems to hit all the notes, thank you!
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds a CLI command to make it easy to read the runs off of a work queue:
My main use case was simulating a worker/agent poll to a work queue to simulate work queue status events. The command was useful during testing and I can image it being useful to test other work queue status related things (i.e. automations, events). Note that running this command is equivalent to a worker polling a work queue and may lead to a temporary false positive where it looks like "something is polling for work" but it was just a one time command.
Example
Checklist
<link to issue>"maintenance,fix,feature,enhancement,docs.For documentation changes:
netlify.tomlfor files that are removed or renamed.For new functions or classes in the Python SDK:
mkdocs.ymlnavigation.