Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix three memory leaks #12019

Merged
merged 10 commits into from
Feb 22, 2024
Merged

Fix three memory leaks #12019

merged 10 commits into from
Feb 22, 2024

Conversation

abrookins
Copy link
Collaborator

@abrookins abrookins commented Feb 16, 2024 •
edited

Fix two three memory leaks. Fixes #10952.

Example

Checklist

  • This pull request references any related issue by including "closes <link to issue>"
    • If no issue exists and your change is not a small fix, please create an issue first.
  • This pull request includes tests or only affects documentation.
  • This pull request includes a label categorizing the change e.g. maintenance, fix, feature, enhancement, docs.

For documentation changes:

  • This pull request includes redirect settings in netlify.toml for files that are removed or renamed.

For new functions or classes in the Python SDK:

  • This pull request includes helpful docstrings.
  • If a new Python file was added, this pull request contains a stub page in the Python SDK docs and an entry in mkdocs.yml navigation.

@netlify Netlify
Copy link

netlify bot commented Feb 16, 2024 •
edited

✅ Deploy Preview for prefect-docs-preview ready!

Name Link
🔨 Latest commit bf3b4d9
🔍 Latest deploy log https://app.netlify.com/sites/prefect-docs-preview/deploys/65d7d59d07d88800082fe709
😎 Deploy Preview https://deploy-preview-12019--prefect-docs-preview.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@abrookins abrookins mentioned this pull request Feb 16, 2024
Closed
3 tasks
@abrookins abrookins mentioned this pull request Feb 21, 2024
Closed
4 tasks
@abrookins abrookins marked this pull request as ready for review February 22, 2024 23:04
@abrookins abrookins requested a review from a team as a code owner February 22, 2024 23:04
@abrookins abrookins changed the title Fix two memory leaks Fix three memory leaks Feb 22, 2024
bunchesofdonald
bunchesofdonald approved these changes Feb 22, 2024
View reviewed changes
Copy link
Contributor

@bunchesofdonald bunchesofdonald left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🙌

@abrookins abrookins merged commit 17f42e9 into main Feb 22, 2024
45 checks passed
@abrookins abrookins deleted the fix-memory-leaks branch February 22, 2024 23:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@chrisguidry chrisguidry chrisguidry left review comments

@bunchesofdonald bunchesofdonald bunchesofdonald approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Task input persisted leading to memory not being released (same for output).
3 participants
@abrookins @chrisguidry @bunchesofdonald