Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Disallow alternate task submission methods #12025

Merged
merged 22 commits into from
Feb 20, 2024

Conversation

zzstoatzz
Copy link
Contributor

stacked on #12008

previously we technically allowed using __call__ and/or .map as "entrypoints" to the engine via enter_task_run_engine where we'd eventually call create_autonomous_task_run regardless, but this PR moves the call so we will fail about not being in a flow run context unless we get there via .submit

Copy link

netlify bot commented Feb 20, 2024

Deploy Preview for prefect-docs-preview ready!

Name Link
🔨 Latest commit 6cb9671
🔍 Latest deploy log https://app.netlify.com/sites/prefect-docs-preview/deploys/65d4bdfe991cb20008e1ac36
😎 Deploy Preview https://deploy-preview-12025--prefect-docs-preview.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@zzstoatzz zzstoatzz marked this pull request as ready for review February 20, 2024 14:58
@zzstoatzz zzstoatzz requested a review from a team as a code owner February 20, 2024 14:58
@zzstoatzz zzstoatzz self-assigned this Feb 20, 2024
Copy link
Collaborator

@chrisguidry chrisguidry left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Very nice!

@zzstoatzz zzstoatzz merged commit a40547d into main Feb 20, 2024
45 checks passed
@zzstoatzz zzstoatzz deleted the disallow-alternate-task-submission-methods branch February 20, 2024 15:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants