-
Notifications
You must be signed in to change notification settings - Fork 1.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[docs] add deep dive on overriding job variables #12033
Conversation
✅ Deploy Preview for prefect-docs-preview ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is great info, Nate! Thank you!
I'm wondering whether we should include this in the Work pool and Workers Guide. That guide is already lengthy, but this is pretty short and fewer guides to navigate is nice. However this guide would be discoverable quickly with search. What do you think?
Separating the .deploy and prefect.yaml sections into tabs is probably a good idea. Given the length, that's less of an issue if we keep it as a stand alone guide.
Please add a <div class="terminal> wrapper around the bash code and output for consitency with other pages.
I intentionally broke this one out because I think the "Deploying Flows to Workers and Work Pools" is already too long.
Will do! |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you for adding this! This will address a large set of common questions.
I proposed a few edits for brevity, none of which I feel strongly about.
Co-authored-by: Bill Palombi <bill@prefect.io>
Co-authored-by: Bill Palombi <bill@prefect.io>
Co-authored-by: Bill Palombi <bill@prefect.io>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'll let you keep working and come back for another review later
…ectHQ/prefect into docs-override-job-variables
Co-authored-by: Kevin Grismore <146098880+kevingrismore@users.noreply.github.com>
Co-authored-by: Kevin Grismore <146098880+kevingrismore@users.noreply.github.com>
Co-authored-by: Kevin Grismore <146098880+kevingrismore@users.noreply.github.com>
Co-authored-by: Kevin Grismore <146098880+kevingrismore@users.noreply.github.com>
Co-authored-by: Kevin Grismore <146098880+kevingrismore@users.noreply.github.com>
…ectHQ/prefect into docs-override-job-variables
Co-authored-by: Kevin Grismore <146098880+kevingrismore@users.noreply.github.com>
@@ -0,0 +1,177 @@ | |||
# Deeper Dive: Overriding Work Pool Job Variables |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
thoughts on renaming this to "2 Dive 2 Deep"?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
😂
@discdiver @billpalombi any other changes you want to see here? |
Thinking about the title on the side bar. What do you think of Job Variable Overrides ? or "Work Pool Job Variable Overrides" to keep it shorter and easier to scan in the side nav? At the top of the page, can you please add the metadata that looks like this? description: Installing Prefect and configuring your environment
|
👍🏼 @discdiver updated in 7d7a155 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Sweet!
Checklist
maintenance
,fix
,feature
,enhancement
,docs
.For documentation changes:
netlify.toml
for files that are removed or renamed.