Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adding a more readable error in case Docker not running #12045

Merged
merged 5 commits into from
Feb 22, 2024

Conversation

eladm26
Copy link
Contributor

@eladm26 eladm26 commented Feb 21, 2024

When deploying using a Docker image we get an unclear error in case Docker is not running on the local machine.
Added a more readable error Runtime Exception: Docker is not running. please run docker and try again

Checklist

For documentation changes:

  • This pull request includes redirect settings in netlify.toml for files that are removed or renamed.

For new functions or classes in the Python SDK:

  • This pull request includes helpful docstrings.
  • If a new Python file was added, this pull request contains a stub page in the Python SDK docs and an entry in mkdocs.yml navigation.

@eladm26 eladm26 requested a review from a team as a code owner February 21, 2024 19:17
Copy link

netlify bot commented Feb 21, 2024

👷 Deploy request for prefect-docs-preview pending review.

Visit the deploys page to approve it

Name Link
🔨 Latest commit 3b9b976

Copy link
Contributor

@discdiver discdiver left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you. One suggested change for wording. Will leave to the engineering team for final approval.

src/prefect/utilities/dockerutils.py Outdated Show resolved Hide resolved
Copy link
Contributor

@zzstoatzz zzstoatzz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

somewhat pedantic comment about wording, just because the user might only see this message through the CLI, so they might not really have "code" to re-run directly.

otherwise, lgtm! 🙂

src/prefect/utilities/dockerutils.py Outdated Show resolved Hide resolved
Copy link
Contributor

@zzstoatzz zzstoatzz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thank you @eladm26 for the contribution 🎉

@zzstoatzz zzstoatzz merged commit de3a7b4 into PrefectHQ:main Feb 22, 2024
41 checks passed
@eladm26 eladm26 deleted the docker-not-running-error branch February 28, 2024 21:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Improve error message when Docker is not running and Prefect tries to build a Docker image
3 participants