-
Notifications
You must be signed in to change notification settings - Fork 1.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Adding a more readable error in case Docker not running #12045
Conversation
👷 Deploy request for prefect-docs-preview pending review.Visit the deploys page to approve it
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you. One suggested change for wording. Will leave to the engineering team for final approval.
715b55b
to
fe4d260
Compare
…e docker not running exception
fe4d260
to
5a9dc44
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
somewhat pedantic comment about wording, just because the user might only see this message through the CLI, so they might not really have "code" to re-run directly.
otherwise, lgtm! 🙂
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
thank you @eladm26 for the contribution 🎉
When deploying using a Docker image we get an unclear error in case Docker is not running on the local machine.
Added a more readable error Runtime Exception:
Docker is not running. please run docker and try again
Checklist
maintenance
,fix
,feature
,enhancement
,docs
.For documentation changes:
netlify.toml
for files that are removed or renamed.For new functions or classes in the Python SDK:
mkdocs.yml
navigation.