do not create default-agent-pool in empty state server
#12214
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
zzstoatzz
changed the base branch from
do-not-create-default-agent-work-pool
to
main
zzstoatzz
changed the title
default-agent-pool in empty state server
✅ Deploy Preview for prefect-docs-preview ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
closes #11984
edits an old data migration that was creating a
default-agent-poolwork pool by default, and associating work-queues with this work poolas it was, this data migration had the misleading side-effect of seeming like a recommendation to new users of the open source server
previously
changes
if we find any work queues that have a
nullwork pool, we keep the status quo and create thedefault agent pool, but in the empty case, we shouldn't find any such work queues, so we just do not create thedefault agent poolor do the downstream queue association