Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove extra field from create endpoints #12240

Merged
merged 3 commits into from
Mar 11, 2024
Merged

Conversation

urimandujano
Copy link
Contributor

@urimandujano urimandujano commented Mar 11, 2024

This PR fixes an issue in our compat tests in our cloud repos. The problem was that our compat test detected that OSS had an extra field in its FlowRunCreate object. That field is getting dropped server side here and client side in 8bcf05e. This should get our compat tests passing again.

Example

Checklist

  • This pull request references any related issue by including "closes <link to issue>"
    • If no issue exists and your change is not a small fix, please create an issue first.
  • This pull request includes tests or only affects documentation.
  • This pull request includes a label categorizing the change e.g. maintenance, fix, feature, enhancement, docs.

For documentation changes:

  • This pull request includes redirect settings in netlify.toml for files that are removed or renamed.

For new functions or classes in the Python SDK:

  • This pull request includes helpful docstrings.
  • If a new Python file was added, this pull request contains a stub page in the Python SDK docs and an entry in mkdocs.yml navigation.

@urimandujano urimandujano requested review from zangell44 and a team as code owners March 11, 2024 15:08
Copy link

netlify bot commented Mar 11, 2024

Deploy Preview for prefect-docs-preview ready!

Name Link
🔨 Latest commit 304ddae
🔍 Latest deploy log https://app.netlify.com/sites/prefect-docs-preview/deploys/65ef2669eb260c00093cd64e
😎 Deploy Preview https://deploy-preview-12240--prefect-docs-preview.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@urimandujano urimandujano merged commit 91b0ac6 into main Mar 11, 2024
45 checks passed
@urimandujano urimandujano deleted the fix/update-bad-oss-field branch March 11, 2024 16:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants