Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix support for legacy schedule in build_from_flow #12257

Merged
merged 3 commits into from Mar 12, 2024
Merged

Conversation

bunchesofdonald
Copy link
Contributor

The recent changes for enhanced scheduling broke the way the legacy schedule parameter worked for build_from_flow. This ensures that the legacy field is able to add and remove schedules, but in the case that both schedule and schedules are provided schedules will be the source of truth.

Closes #12255

Checklist

  • This pull request references any related issue by including "closes <link to issue>"
    • If no issue exists and your change is not a small fix, please create an issue first.
  • This pull request includes tests or only affects documentation.
  • This pull request includes a label categorizing the change e.g. maintenance, fix, feature, enhancement, docs.

For documentation changes:

  • This pull request includes redirect settings in netlify.toml for files that are removed or renamed.

For new functions or classes in the Python SDK:

  • This pull request includes helpful docstrings.
  • If a new Python file was added, this pull request contains a stub page in the Python SDK docs and an entry in mkdocs.yml navigation.

@bunchesofdonald bunchesofdonald added the fix A fix for a bug in an existing feature label Mar 12, 2024
@bunchesofdonald bunchesofdonald requested a review from a team as a code owner March 12, 2024 16:35
Copy link

netlify bot commented Mar 12, 2024

Deploy Preview for prefect-docs-preview ready!

Name Link
🔨 Latest commit 9ed4532
🔍 Latest deploy log https://app.netlify.com/sites/prefect-docs-preview/deploys/65f096590f980e00089ec2b1
😎 Deploy Preview https://deploy-preview-12257--prefect-docs-preview.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

Copy link
Collaborator

@abrookins abrookins left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good 👍

@bunchesofdonald bunchesofdonald merged commit 383a097 into main Mar 12, 2024
45 checks passed
@bunchesofdonald bunchesofdonald deleted the issue-12255 branch March 12, 2024 19:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
fix A fix for a bug in an existing feature
Projects
None yet
Development

Successfully merging this pull request may close these issues.

"schedule" not recognised in Deployment.build_from_flow
2 participants