Hydrate run input when resuming a flow run #12259
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
✅ Deploy Preview for prefect-docs-preview ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
jakekaplan
approved these changes
Mar 13, 2024
| @@ -364,6 +366,21 @@ async def resume_flow_run( | |||
| if keyset: | |||
| run_input = run_input or {} | |||
|
|
|||
| if experiment_enabled("enhanced_deployment_parameters"): | |||
There was a problem hiding this comment.
Not sure if we want a different experiment or not. I think it's probably overkill to have more but just want to align with w/e @pleek91 needs
There was a problem hiding this comment.
Yeah, I debated it and decided to go this route, but happy to add another if we think it's needed.
There was a problem hiding this comment.
I assumed we would use the same flag 👍
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This adds support for hydrating run input before comparing it against the resume schema.
OSS side of https://github.com/PrefectHQ/nebula/pull/7192