Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Deprecate Infrastructrue blocks #12282

Merged
merged 8 commits into from Mar 13, 2024
Merged

Deprecate Infrastructrue blocks #12282

merged 8 commits into from Mar 13, 2024

Conversation

desertaxle
Copy link
Member

@desertaxle desertaxle commented Mar 13, 2024 •
edited

Adds deprecation warnings to all of the infrastructure blocks contained in prefect.infrastructure.

Example

Checklist

  • This pull request references any related issue by including "closes <link to issue>"
    • If no issue exists and your change is not a small fix, please create an issue first.
  • This pull request includes tests or only affects documentation.
  • This pull request includes a label categorizing the change e.g. maintenance, fix, feature, enhancement, docs.

For documentation changes:

  • This pull request includes redirect settings in netlify.toml for files that are removed or renamed.

For new functions or classes in the Python SDK:

  • This pull request includes helpful docstrings.
  • If a new Python file was added, this pull request contains a stub page in the Python SDK docs and an entry in mkdocs.yml navigation.

@netlify Netlify
Copy link

netlify bot commented Mar 13, 2024 •
edited

✅ Deploy Preview for prefect-docs-preview ready!

Name Link
🔨 Latest commit 4d40c56
🔍 Latest deploy log https://app.netlify.com/sites/prefect-docs-preview/deploys/65f1f64e75287b0009a46779
😎 Deploy Preview https://deploy-preview-12282--prefect-docs-preview.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@desertaxle desertaxle added the deprecation This feature has been marked for removal label Mar 13, 2024
@desertaxle desertaxle marked this pull request as ready for review March 13, 2024 18:36
@desertaxle desertaxle requested a review from a team as a code owner March 13, 2024 18:36
serinamarie
serinamarie approved these changes Mar 13, 2024
View reviewed changes
Copy link
Contributor

@serinamarie serinamarie left a comment •
edited

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

src/prefect/infrastructure/base.py Outdated Show resolved Hide resolved
src/prefect/testing/utilities.py Outdated Show resolved Hide resolved
@desertaxle desertaxle merged commit ef2e4d5 into main Mar 13, 2024
45 checks passed
@desertaxle desertaxle deleted the deprecate/infra-blocks branch March 13, 2024 19:25
bunchesofdonald pushed a commit that referenced this pull request Mar 14, 2024
@desertaxle @bunchesofdonald
Deprecate Infrastructrue blocks (#12282)
269895b
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@serinamarie serinamarie serinamarie approved these changes

Assignees
No one assigned
Labels
deprecation This feature has been marked for removal
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@desertaxle @serinamarie