Deprecate Deployment class and deployment build and apply commands
#12283
+135
−18
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
✅ Deploy Preview for prefect-docs-preview ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
serinamarie
approved these changes
Mar 13, 2024
| " Refer to the upgrade guide for more information" | ||
| ), | ||
| ): | ||
| Deployment(name="foo") |
Co-authored-by: Serina Grill <42048900+serinamarie@users.noreply.github.com>
Co-authored-by: Serina Grill <42048900+serinamarie@users.noreply.github.com>
We'll have an explanation in the release notes tomorrow that will cover the motivation behind these deprecations. I updated the description of this PR slightly, but I can add more detail tomorrow while working on a release notes highlight. |
|
Awesome! |
bunchesofdonald
pushed a commit
that referenced
this pull request
Mar 14, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds a deprecation warning to the
Deploymentclass along with the the deploymentbuildandapplycommands in lieu offlow.deployandprefect deploy. Adds some logic to enable deprecation of specific commands in addition to full command groups.Example
Checklist
<link to issue>"maintenance,fix,feature,enhancement,docs.For documentation changes:
netlify.tomlfor files that are removed or renamed.For new functions or classes in the Python SDK:
mkdocs.ymlnavigation.