Feature: JSON Artifacts #12295
Merged
Feature: JSON Artifacts #12295
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
✅ Deploy Preview for prefect-docs-preview ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
jakekaplan
reviewed
Mar 14, 2024
jakekaplan
reviewed
Mar 14, 2024
jakekaplan
reviewed
Mar 14, 2024
jakekaplan
reviewed
Mar 14, 2024
jakekaplan
reviewed
Mar 14, 2024
jakekaplan
reviewed
Mar 14, 2024
jakekaplan
reviewed
Mar 14, 2024
|
@jakekaplan want to give it another once over? |
serinamarie
reviewed
Mar 21, 2024
Comment on lines
+29
to
+35
| Arguments: | ||
| type: A string identifying the type of artifact. | ||
| key: A user-provided string identifier. | ||
| The key must only contain lowercase letters, numbers, and dashes. | ||
| description: A user-specified description of the artifact. | ||
| data: A JSON payload that allows for a result to be retrieved. | ||
| """ |
There was a problem hiding this comment.
should we note the optional args here?
jakekaplan
reviewed
Mar 21, 2024
| data: Optional[Union[Dict[str, Any], Any]] = None, | ||
| client: Optional[PrefectClient] = None, | ||
| **kwargs: Any, | ||
| ) -> Tuple[ArtifactResponse, bool]: |
There was a problem hiding this comment.
What would you think about this just returning the artifact? It feels more unified with the other methods to keep the response shape/type the same.
There was a problem hiding this comment.
I am part of the anti-tuple response movement 🙃
jakekaplan
reviewed
Mar 21, 2024
Comment on lines
+82
to
+85
| await client.read_artifacts( | ||
| limit=1, | ||
| sort=ArtifactSort.UPDATED_DESC, | ||
| artifact_filter=ArtifactFilter(key=ArtifactFilterKey(any_=[key])), |
There was a problem hiding this comment.
I think you'll need to add a client method for it but there is a more efficient lookup here:
https://github.com/PrefectHQ/prefect/blob/main/src/prefect/server/api/artifacts.py#L64-L80
jakekaplan
reviewed
Mar 21, 2024
jakekaplan
approved these changes
Mar 21, 2024
serinamarie
pushed a commit
that referenced
this pull request
Apr 5, 2024
Co-authored-by: Andrew Brookins <andrew.b@prefect.io>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Mostly a refactor of our public artifact methods.
The biggest change is a new public class-based interface to Artifacts, which:
json.getby key, which was previously available only through the CLI.get_or_createby key, which does what you think it does.I'm doing a draft PR