Deprecate storage blocks with implementations in Prefect integration packages #12299
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
✅ Deploy Preview for prefect-docs-preview ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
chrisguidry
approved these changes
Mar 14, 2024
src/prefect/filesystems.py
Outdated
| DEPRECATION WARNING: | ||
|
|
||
| This class is deprecated as of March 2024 and will not be available after September 2024. | ||
| It has been replaced by `S3Bucket` from the prefect-aws package, which offers enhanced functionality |
There was a problem hiding this comment.
Suggested change
| It has been replaced by `S3Bucket` from the prefect-aws package, which offers enhanced functionality | |
| It has been replaced by `S3Bucket` from the `prefect-aws` package, which offers enhanced functionality |
maybe?
There was a problem hiding this comment.
I'm sure you're already thinking about this @desertaxle but the other PRs didn't have backticks on package names, so that might be good to be consistent on.
src/prefect/filesystems.py
Outdated
| DEPRECATION WARNING: | ||
|
|
||
| This class is deprecated as of March 2024 and will not be available after September 2024. | ||
| It has been replaced by `AzureBlobStorageContainer` from the prefect-azuer package, which |
There was a problem hiding this comment.
Suggested change
| It has been replaced by `AzureBlobStorageContainer` from the prefect-azuer package, which | |
| It has been replaced by `AzureBlobStorageContainer` from the prefect-azure package, which |
serinamarie
reviewed
Mar 14, 2024
|
|
||
| This class is deprecated as of March 2024 and will not be available after September 2024. | ||
| It has been replaced by `S3Bucket` from the prefect-aws package, which offers enhanced functionality | ||
| and better a better user experience. |
There was a problem hiding this comment.
Suggested change
| and better a better user experience. | |
| and a better user experience. |
serinamarie
reviewed
Mar 14, 2024
|
|
||
| This class is deprecated as of March 2024 and will not be available after September 2024. | ||
| It has been replaced by `GcsBucket` from the prefect-gcp package, which offers enhanced functionality | ||
| and better a better user experience. |
There was a problem hiding this comment.
Suggested change
| and better a better user experience. | |
| and a better user experience. |
serinamarie
reviewed
Mar 14, 2024
|
|
||
| This class is deprecated as of March 2024 and will not be available after September 2024. | ||
| It has been replaced by `AzureBlobStorageContainer` from the prefect-azuer package, which | ||
| offers enhanced functionality and better a better user experience. |
There was a problem hiding this comment.
Suggested change
| offers enhanced functionality and better a better user experience. | |
| offers enhanced functionality and a better user experience. |
serinamarie
reviewed
Mar 14, 2024
src/prefect/filesystems.py
Outdated
|
|
||
| This class is deprecated as of March 2024 and will not be available after September 2024. | ||
| It has been replaced by `GitHubRepository` from the prefect-github package, which offers | ||
| enhanced functionality and better a better user experience. |
There was a problem hiding this comment.
Suggested change
| enhanced functionality and better a better user experience. | |
| enhanced functionality and a better user experience. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds deprecation warnings to the
S3,GCS,Azure, andGitHubblocks in thefilesystemsmodule. These blocks have implementations in Prefect integration packages that offer more functionality and a better user experience. These blocks will be removed from the core package to prevent confusion around blocks that appear to be duplicates.Requires PrefectHQ/prefect-azure#139
Example
Checklist
<link to issue>"maintenance,fix,feature,enhancement,docs.For documentation changes:
netlify.tomlfor files that are removed or renamed.For new functions or classes in the Python SDK:
mkdocs.ymlnavigation.