Integrating composite triggers with the DeploymentTrigger YAML representation
#12413
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
✅ Deploy Preview for prefect-docs-preview ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
serinamarie
reviewed
Mar 25, 2024
|
That's a great call, @serinamarie, I'll try to get some of those in today |
|
It turns out that we do have a set of integration tests over in I'm still not satisfied with how this works, so I'm going to do some more work on it to reflect the real triggers class hierarchy |
As I was starting to write more tests for DeploymentTrigger, I realized that I was effectively reproducing tests for validation that Pydantic would do for us if we just matched the hierarchy correctly. Unfortunately there's no way to inject a few fields into a base class for another class hierarchy, so I'm reproducing the full hierarchy and its validate rules here.
chrisguidry
force-pushed
the
composite-triggers-in-deployments
branch
from
f808c80
to
159d02d
Compare
jakekaplan
approved these changes
Mar 26, 2024
serinamarie
reviewed
Mar 26, 2024
| @@ -207,6 +207,93 @@ def test_compound_deployment_trigger_as_automation(): | |||
| ) | |||
|
|
|||
|
|
|||
| def test_deeply_nested_compound_deployment_trigger_as_automation(): | |||
serinamarie
approved these changes
Mar 26, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
It wasn't apparent to me the first time that just backporting the
Triggerhierarchy andTriggerTypeswasn't enough to get them to be available in deployments. This adds them to theDeploymentTriggerschema so that folks can define them in theirprefect.yamlfiles and get full support of the nested triggers.