Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow prefect cloud login to override current workspace #12867

Merged
merged 5 commits into from Apr 25, 2024
Merged

Conversation

zzstoatzz
Copy link
Contributor

closes #12859


as outlined in the issue, #12717 introduced a regression in prefect cloud login where the current workspace took precedence over a provided workspace handle

this PR fixes that and adds a test for that case

@zzstoatzz zzstoatzz added the fix A fix for a bug in an existing feature label Apr 24, 2024
Copy link

netlify bot commented Apr 24, 2024

Deploy Preview for prefect-docs-preview ready!

Name Link
🔨 Latest commit bd13523
🔍 Latest deploy log https://app.netlify.com/sites/prefect-docs-preview/deploys/662a4a48912589000833a9fb
😎 Deploy Preview https://deploy-preview-12867--prefect-docs-preview.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

tests/cli/test_cloud.py Outdated Show resolved Hide resolved
@zzstoatzz zzstoatzz marked this pull request as ready for review April 24, 2024 19:59
@zzstoatzz zzstoatzz requested a review from a team as a code owner April 24, 2024 19:59
@zzstoatzz zzstoatzz merged commit 9e02a25 into main Apr 25, 2024
58 checks passed
@zzstoatzz zzstoatzz deleted the fix-login branch April 25, 2024 13:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
fix A fix for a bug in an existing feature
Projects
None yet
Development

Successfully merging this pull request may close these issues.

prefect login regression
2 participants