Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Google Cloud Storage -> BigQuery task #1317

Merged
merged 7 commits into from
Aug 7, 2019

Conversation

bnaul
Copy link

@bnaul bnaul commented Aug 6, 2019

Thanks for contributing to Prefect!

Please describe your work and make sure your PR:

  • adds new tests (if appropriate)
  • updates CHANGELOG.md (if appropriate)
  • updates docstrings for any new functions or function arguments, including docs/outline.toml for API reference docs (if appropriate)

Note that your PR will not be reviewed unless all three boxes are checked.

What does this PR change?

Fixes #1246 by adding new task for GCS -> BQ.

Why is this PR important?

Streaming inserts are nice but loading from GCS feels like an equally important use case.

@bnaul bnaul changed the title Add Google Cloud Storage -> Bigquery task Add Google Cloud Storage -> BigQuery task Aug 6, 2019
@codecov
Copy link

codecov bot commented Aug 6, 2019

Codecov Report

Merging #1317 into master will decrease coverage by 0.13%.
The diff coverage is 58.33%.

Copy link
Member

@cicdw cicdw left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is great! I ran into needing this exact task a few days ago. Would you mind adding this task to the docs outline here?

@bnaul
Copy link
Author

bnaul commented Aug 7, 2019

This is great! I ran into needing this exact task a few days ago. Would you mind adding this task to the docs outline here?

👍 done

Copy link
Member

@cicdw cicdw left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Excellent - thanks @bnaul! Great addition to the library.

@cicdw cicdw merged commit faa6999 into PrefectHQ:master Aug 7, 2019
@bnaul bnaul deleted the bigquery_load branch October 24, 2019 22:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

BigQuery Load Job Task
2 participants