Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

DaskKubernetesEnvironment #1338

Merged
merged 9 commits into from
Aug 9, 2019
Merged

DaskKubernetesEnvironment #1338

merged 9 commits into from
Aug 9, 2019

Conversation

cicdw
Copy link
Member

@cicdw cicdw commented Aug 9, 2019

Thanks for contributing to Prefect!

Please describe your work and make sure your PR:

  • adds new tests (if appropriate)
  • updates CHANGELOG.md (if appropriate)
  • updates docstrings for any new functions or function arguments, including docs/outline.toml for API reference docs (if appropriate)

Note that your PR will not be reviewed unless all three boxes are checked.

What does this PR change?

This PR renames the old CloudEnvironment to DaskKubernetesEnvironment and also introduces two new keywords for specifying the min / max number of dask worker pods. Closes #1250

Also polishes up some unrelated secrets documentation.

Why is this PR important?

It's important to start introducing and testing new execution environments for maximum flexibility.

@codecov
Copy link

codecov bot commented Aug 9, 2019

Codecov Report

Merging #1338 into master will increase coverage by <.01%.
The diff coverage is 100%.

jlowin
jlowin previously approved these changes Aug 9, 2019
Copy link
Member

@jlowin jlowin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice

Copy link

@joshmeek joshmeek left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Comments :)

@cicdw
Copy link
Member Author

cicdw commented Aug 9, 2019

Updated! Good catches.

@cicdw cicdw merged commit ba079c2 into master Aug 9, 2019
@cicdw cicdw deleted the dask-env branch August 9, 2019 16:01
abrookins pushed a commit that referenced this pull request Mar 15, 2022
Admin: Bumping orion-design version
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Rename CloudEnvironment -> DaskKubernetesEnvironment
3 participants