Remove Infrastructure, BlockWorker from main
#13430
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
serinamarie
requested review from
desertaxle,
zzstoatzz and
a team
as code owners
desertaxle
approved these changes
May 17, 2024
| @@ -130,7 +128,7 @@ class ACRManagedIdentity(BaseModel): | |||
| ) | |||
|
|
|||
|
|
|||
| class AzureContainerInstanceJobResult(InfrastructureResult): | |||
| class AzureContainerInstanceJobResult: | |||
There was a problem hiding this comment.
Is this class still used somewhere? I think it can be removed
There was a problem hiding this comment.
Yeah, the worker return type /type hints
| @@ -390,5 +388,5 @@ def get( | |||
| ) | |||
|
|
|||
|
|
|||
| class CloudRunJobV2Result(InfrastructureResult): | |||
| class CloudRunJobV2Result: | |||
There was a problem hiding this comment.
I think this class can also be removed.
There was a problem hiding this comment.
It is a type hint for return type for CloudRunWorkerV2. Removing the type hints ok?
There was a problem hiding this comment.
I'm just merging this for now to unblock another PR but happy to remove these after if so!
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #13362
Removes
prefect.infrastructure.basemodule and references. Also removes theBlockWorker.Important Note
Infrastructure will be included with 2.x releases, but will not be included in the 3.0 release.