Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove prefect-agent as a possible work pool type #13444

Merged
merged 4 commits into from
May 18, 2024

Conversation

desertaxle
Copy link
Member

@desertaxle desertaxle commented May 17, 2024

Removes prefect-agent as a selectable work pool type. PrefectAgent has been removed for the 3.0 release, so this is no longer needed. The collection registry will still contain data for the prefect-agent work pool type until PrefectAgent is removed from the 2.x line.

Example

Checklist

  • This pull request references any related issue by including "closes <link to issue>"
    • If no issue exists and your change is not a small fix, please create an issue first.
  • If this pull request adds new functionality, it includes unit tests that cover the changes
  • This pull request includes a label categorizing the change e.g. maintenance, fix, feature, enhancement, docs.

For documentation changes:

  • This pull request includes redirect settings in netlify.toml for files that are removed or renamed.

For new functions or classes in the Python SDK:

  • This pull request includes helpful docstrings.
  • If a new Python file was added, this pull request contains a stub page in the Python SDK docs and an entry in mkdocs.yml navigation.

@desertaxle desertaxle requested review from zangell44 and a team as code owners May 17, 2024 20:02
Copy link
Contributor

@serinamarie serinamarie left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

tests/server/api/test_collections.py Show resolved Hide resolved
@desertaxle desertaxle merged commit 73b8e73 into main May 18, 2024
26 checks passed
@desertaxle desertaxle deleted the remove-prefect-agent-option branch May 18, 2024 03:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants