Fix local retries in Cloud to always run in-process #1348
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cicdw
commented
Aug 11, 2019
| assert ( | ||
| client.set_task_run_state.call_count == 5 | ||
| ) # Pending -> Running -> Failed -> Retrying -> Running -> Success | ||
| versions = [call[1]["version"] for call in client.set_task_run_state.call_args_list] | ||
| assert versions == [1, 2, 3, 4, 5] |
There was a problem hiding this comment.
Previously this test failed because versions = [1, 2, 3, 1, 2]
jlowin
approved these changes
Aug 11, 2019
abrookins
pushed a commit
that referenced
this pull request
Mar 15, 2022
…sign Clean up route guards. Use panel guard from orion-design
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Thanks for contributing to Prefect!
Please describe your work and make sure your PR:
CHANGELOG.md(if appropriate)docs/outline.tomlfor API reference docs (if appropriate)Note that your PR will not be reviewed unless all three boxes are checked.
What does this PR change?
This PR makes an additional call to
get_task_run_infowhenever tasks have to retry locally. Previously, prefect context was reset to its original state, meaning the task run version that was present in context was stale on the next run, preventing the retry from actually occurring in process (instead it occurred in a new run). Note that local retries were properly working for mapped tasks because of the additional call toget_task_run_infothat mapped tasks always perform prior to a run.Why is this PR important?
It is much more efficient to retry in the same process for short duration retries.