-
Notifications
You must be signed in to change notification settings - Fork 1.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update Variable.set
return value + docs
#13557
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you. One suggestion.
Co-authored-by: Jeff Hale <discdiver@users.noreply.github.com>
Co-authored-by: Jeff Hale <discdiver@users.noreply.github.com>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Couple nits
Co-authored-by: Bill Palombi <bill@prefect.io>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
One suggestion and looks like maybe one from Bill still, but approving for docs.
Co-authored-by: Jeff Hale <discdiver@users.noreply.github.com>
Co-authored-by: Jeff Hale <discdiver@users.noreply.github.com>
This PR updates
Variable.set
to return the newly setvalue
by default. If you passas_object
it will return the entireVariable
object. This makes it a consistent interface with theget
method.This pr also updates the docs for the new
get
,set
andunset
interfaces. It also take into account the changes to@sync_compatible
for when these methods can be used synchronously vs asynchronously.