-
Notifications
You must be signed in to change notification settings - Fork 1.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update RayTaskRunner
for compatibility with new engine
#13575
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
desertaxle
commented
May 27, 2024
@@ -11,7 +11,7 @@ | |||
from prefect.utilities.engine import collect_task_run_inputs_sync | |||
|
|||
|
|||
class PrefectDistributedClient(Client): | |||
class PrefectDaskClient(Client): |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I also renamed this client to be more consistent with the DaskTaskRunner
and PrefectDaskFuture
.
zzstoatzz
approved these changes
May 28, 2024
cicdw
approved these changes
May 28, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Updates the
RayTaskRunner
to be compatible with the new engine. I also moved the.map
logic on theTaskRunner
subclasses to the base class since it was the same between all threeTaskRunner
implementations.I wanted to create a lower-level utility for running tasks with Ray's
@ray.remote
decorator, but Ray only allows functions and classes to be decorated with@ray.remote,
, and I was having trouble smuggling atask_run_id
on the returnedObjectRef
. I think there's still lower-level utility hiding in there, but I figured I'd work backward from a working task runner.Example
Checklist
<link to issue>
"maintenance
,fix
,feature
,enhancement
,docs
.For documentation changes:
netlify.toml
for files that are removed or renamed.For new functions or classes in the Python SDK:
mkdocs.yml
navigation.