-
Notifications
You must be signed in to change notification settings - Fork 1.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Remove old task runners and futures modules #13593
Conversation
27509ba
to
9230f96
Compare
@@ -24,7 +24,7 @@ | |||
|
|||
|
|||
async def main(timeout): | |||
async with anyio.move_on_after(timeout): | |||
with anyio.move_on_after(timeout): |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This fixes the failures we've been seeing with the benchmarks job
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good to me. 👍
One question I have that isn't directly about this PR but that it reminded me of is why did we remove the SequentialTaskRunner? I get that it doesn't serve a purpose in production code, but I thought it was there to help people write tests for their flows easier. 🤔 |
I removed it because the |
Moves
new_task_runners
andnew_futures
totask_runners
andfutures
, respectively. Deletes oldtask_runners
andfuture
modules.Example
Checklist
<link to issue>
"maintenance
,fix
,feature
,enhancement
,docs
.For documentation changes:
netlify.toml
for files that are removed or renamed.For new functions or classes in the Python SDK:
mkdocs.yml
navigation.