Replace our customized Duration types with plain timedeltas
#13603
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
As I was trying to reconcile the schemas between OSS and Cloud, I discovered that there's a model configuration called `ser_json_timedelta` where we can easily toggle the original behavior of serializing to floats. No need for custom types at all.
aaazzam
approved these changes
May 28, 2024
zzstoatzz
approved these changes
May 28, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As I was trying to reconcile the schemas between OSS and Cloud, I discovered
that there's a model configuration called
ser_json_timedeltawhere we caneasily toggle the original behavior of serializing to floats. No need for
custom types at all.