migrate prefect-docker to pydantic 2
#13697
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
chrisguidry
approved these changes
May 31, 2024
| @@ -68,6 +62,9 @@ class ImagePullPolicy(enum.Enum): | |||
| NEVER = "Never" | |||
|
|
|||
|
|
|||
| VolumeStr = Annotated[str, AfterValidator(lambda v: ":" in v)] | |||
setup.cfg
Outdated
| @@ -114,4 +114,4 @@ format = parsable | |||
| eval_annotations = yes | |||
| only_show_violations = yes | |||
| targets = 3.9- | |||
| exclusion_regex = ^src/prefect/_vendor/.*$|^src/prefect/utilities/compat\.py$|^src/prefect/engine/flow_runner\.py$|^src/prefect/engine/task_runner\.py$|^src/prefect/engine/executor\.py$|^src/prefect/engine/result\.py$|^src/prefect/engine/runner\.py$|^src/prefect/engine/flow_runner\.py$|^src/prefect/engine/task_runner\.py$|^src/prefect/engine/executor\.py$|^src/prefect/engine/result\.py$|^src/prefect/engine/runner\.py$|^src/prefect/engine/flow_runner\.py$|^src/prefect/engine/task_runner\.py$|^src/prefect/engine/executor\.py$|^src/prefect/engine/result\.py$|^src/prefect/engine/runner\.py$|^src/prefect/engine/flow_runner\.py$|^src/prefect/engine/task_runner\.py$|^src/prefect/engine/executor\.py$|^src/prefect/engine/result\.py$|^src/prefect/engine/runner\.py$|^src/prefect/engine/flow_runner\.py$|^src/prefect/engine/task_runner\.py$|^src/prefect/engine/executor\.py$|^src/prefect/engine/result\.py$|^src/prefect/engine/runner\.py$|^src/prefect/engine/flow_runner\.py$|^src/prefect/engine/task_runner\.py$|^src/prefect/engine/executor\.py$|^src/prefect/engine/result\.py$|^src/prefect/engine/runner\.py$|^src/prefect/engine/flow_runner\.py$|^src/prefect/engine/task_runner\.py$|^src/prefect/engine/executor\.py$|^src/prefect/engine/result\.py$|^src/prefect/engine/runner\.py$|^src/prefect/engine/flow_runner\.py$|^src/prefect/engine/task_runner\.py$|^src/prefect/engine/executor\.py$|^src/prefect/engine/result\.py$|^src/prefect/engine/runner\.py$|^src/prefect/engine/flow_runner\.py$|^src/prefect/engine/task_runner\.py$|^src/prefect/engine/executor\.py$|^src/prefect/engine/result\.py$|^tests/workers/test_process_worker.py$|^tests/test_background_tasks.py$ | |||
| exclusion_regex = ^src/prefect/_vendor/.*$|^src/prefect/utilities/compat\.py$|^src/prefect/engine/flow_runner\.py$|^src/prefect/engine/task_runner\.py$|^src/prefect/engine/executor\.py$|^src/prefect/engine/result\.py$|^src/prefect/engine/runner\.py$|^src/prefect/engine/flow_runner\.py$|^src/prefect/engine/task_runner\.py$|^src/prefect/engine/executor\.py$|^src/prefect/engine/result\.py$|^src/prefect/engine/runner\.py$|^src/prefect/engine/flow_runner\.py$|^src/prefect/engine/task_runner\.py$|^src/prefect/engine/executor\.py$|^src/prefect/engine/result\.py$|^src/prefect/engine/runner\.py$|^src/prefect/engine/flow_runner\.py$|^src/prefect/engine/task_runner\.py$|^src/prefect/engine/executor\.py$|^src/prefect/engine/result\.py$|^src/prefect/engine/runner\.py$|^src/prefect/engine/flow_runner\.py$|^src/prefect/engine/task_runner\.py$|^src/prefect/engine/executor\.py$|^src/prefect/engine/result\.py$|^src/prefect/engine/runner\.py$|^src/prefect/engine/flow_runner\.py$|^src/prefect/engine/task_runner\.py$|^src/prefect/engine/executor\.py$|^src/prefect/engine/result\.py$|^src/prefect/engine/runner\.py$|^src/prefect/engine/flow_runner\.py$|^src/prefect/engine/task_runner\.py$|^src/prefect/engine/executor\.py$|^src/prefect/engine/result\.py$|^src/prefect/engine/runner\.py$|^src/prefect/engine/flow_runner\.py$|^src/prefect/engine/task_runner\.py$|^src/prefect/engine/executor\.py$|^src/prefect/engine/result\.py$|^src/prefect/engine/runner\.py$|^src/prefect/engine/flow_runner\.py$|^src/prefect/engine/task_runner\.py$|^src/prefect/engine/executor\.py$|^src/prefect/engine/result\.py$|^tests/workers/test_process_worker.py$|^tests/test_background_tasks.py|^src/integrations/.*/tests/.*$ | |||
There was a problem hiding this comment.
Why wouldn't we need the tests to pass vermin? They will run on each supported Python version, right?
There was a problem hiding this comment.
vermin doesn’t exclude exceptiongroup as a package like it does typing_annotations, so it just reads ExceptionGroup and says “nuh uh that’s not valid on 3.9”
There was a problem hiding this comment.
though we should be a little less ham fisted with excluding all tests
There was a problem hiding this comment.
How about this: https://github.com/netromdk/vermin?tab=readme-ov-file#analysis-exclusions
# novermin?
Comment on lines
+220
to
+227
| with pytest.raises(ExceptionGroup) as exc: | ||
| async with DockerWorker(work_pool_name="test") as worker: | ||
| await worker.run( | ||
| flow_run=flow_run, configuration=default_docker_worker_job_configuration | ||
| ) | ||
| assert len(exc.value.exceptions) == 1 | ||
| assert isinstance(exc.value.exceptions[0], docker.errors.APIError) | ||
| assert "test error" in str(exc.value.exceptions[0]) |
There was a problem hiding this comment.
Interesting, what's the advantage of the ExceptionGroup here if we're just going to make sure it's a very precise exception anyway?
There was a problem hiding this comment.
we run tests in anyio threads and anyio > 4 now doesn’t throw errors it only throws exception groups
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.