-
Notifications
You must be signed in to change notification settings - Fork 1.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix load_flow_argument_from_entrypoint
to work with async flows
#13716
Conversation
…deployments and utilities files
Hi @elisalimli thanks for opening your first PR to Update: You probably want to install pre-commit hooks. Please see our contributing guide. |
Thanks for the PR @elisalimli! Could you please add a test case to cover this case? |
Thanks for the quick response @desertaxle and @serinamarie. @desertaxle I have added a test case in 60b5602 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lgtm!
cc @desertaxle
This issue blocks us as a team right now, therefore we would be glad if you could merge within today/tomorrow. Thanks in advance! |
Likely related to #13765 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks!
load_flow_argument_from_entrypoint
to work with async flows
…3716) Co-authored-by: Serina Grill <42048900+serinamarie@users.noreply.github.com>
Fixes #13765
The
load_flow_argument_from_entrypoint
function in Prefect doesn't support finding async functions (AsyncFunctionDef) decorated with @flow.What We Expect:
It should be able to find both async functions and regular functions (FunctionDef) decorated with @flow.