Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Pydantic v2 prefect dbt 2 #13718

Merged
merged 4 commits into from
May 31, 2024
Merged

Pydantic v2 prefect dbt 2 #13718

merged 4 commits into from
May 31, 2024

Conversation

aaazzam
Copy link
Contributor

@aaazzam aaazzam commented May 31, 2024

No description provided.

"commands instead"
)
return commands
# @validator("commands", always=True)
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

can this get removed or needs to stay commented?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thanks I'll remove it.

it's nice UX but not necessary

Copy link
Collaborator

@chrisguidry chrisguidry left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

All makes sense to me!

@aaazzam aaazzam merged commit 839c3b0 into main May 31, 2024
8 of 16 checks passed
@aaazzam aaazzam deleted the pydantic-v2-prefect-dbt-2 branch May 31, 2024 16:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants