-
Notifications
You must be signed in to change notification settings - Fork 1.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Updates PrefectDistributedFuture
to use an event websocket to determine task completion
#13763
Conversation
8f7493c
to
6769bcd
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
this is really cool! I really like the idea of using the consumer here
wondering if you ran into any pubsub "backup" that caused us to wait longer than we really should have for the event to trickle through? just thinking through the tradeoffs
@overload | ||
def get_client( | ||
httpx_settings: Optional[Dict[str, Any]] = None, sync_client: Literal[False] = False | ||
) -> "PrefectClient": | ||
... | ||
|
||
|
||
@overload | ||
def get_client( | ||
httpx_settings: Optional[Dict[str, Any]] = None, sync_client: Literal[True] = True | ||
) -> "SyncPrefectClient": | ||
... | ||
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
🙇
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good to me!
Our latency has improved a ton since we removed logs from the rest of the events stream, but it is something that we'll need to keep an eye on. |
d1ac6e8
to
40556c7
Compare
Example
Flows like this still work (assuming you're running the appropriate task worker):
Checklist
<link to issue>
"maintenance
,fix
,feature
,enhancement
,docs
.For documentation changes:
mint.json
for files that are removed or renamed.For new functions or classes in the Python SDK:
docs/mint.json
navigation.