-
Notifications
You must be signed in to change notification settings - Fork 1.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
support retry_delay_seconds
in task engine
#13815
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
zzstoatzz
changed the title
support
support Jun 5, 2024
retry_delay_seconds
retry_delay_seconds
in task engine
zzstoatzz
commented
Jun 5, 2024
desertaxle
reviewed
Jun 5, 2024
…m/prefecthq/prefect into task-retry-delay-seconds-refactor
desertaxle
approved these changes
Jun 5, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM!
4 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
supersedes #13785 and #13796
this PR updates
handle_retry
in the task engine to supportretry_delay_seconds
as aint | float | Sequence[int | float] | Callable
handle_retry
will:Retrying()
if no delayAwaitingRetry()
if there's a retry delay with a delayed scheduled timea new
async
methodwait_until_ready
on the engine (which isrun_sync_as_coro
to in the sync case to avoid duplication) willsleep
until the scheduled run timenotably, this PR will handle the case where the number of attempted task retries is greater than
len(retry_delay_seconds)
(when its aSequence
) by repeating the final delay in theSequence