Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR updates cache policies in the following ways:
compute_key
to be closer to the originalcache_key_fn
signaturecache_key_fn
's toCacheKeyFnPolicy
's for backwards compatibilityoverwrite
flag on transactions that can be used to ignore existing records; the engine currently matches this to the originalrefresh_cache
functionalityNOTE: cache expirations are not currently wired up; that will require some extensions to cache policies that will need to be handled separately
cc: @EmilRex (I won't keep doing this I promise haha - this just dovetails nicely with our conversations this week so wanted you to know when these milestones are complete)